Repository navigation
fix(settings): keep no database connection in a web process under uvicorn - #1203
Open
tintinhamans wants to merge 1 commit into
Open
tintinhamans wants to merge 1 commit into
tintinhamans wants to merge 1 commit into
Conversation
…corn Signed-off-by: tintinhamans <5984296+tintinhamans@users.noreply.github.com>
tintinhamans
marked this pull request as draft
November 13, 2026 18:53
tintinhamans
marked this pull request as ready for review
November 13, 2026 22:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Under uvicorn every request runs in its own thread, so #946's 60 second
CONN_MAX_AGEfor web processes leaves a connection behind with each one. On our instance the web workers ended up holding 87 of 100 connections and the API started returning 500s.Web processes are back on Django's default of 0.
DATABASE_CONN_MAX_AGEstill overrides it. This brings back the per-request connect that #946 measured; Django's connection pool is the way to get reuse back under ASGI, I'll do that in a follow-up.Full API suite, migrations and linters pass locally on PostgreSQL 18.
ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
Assisted-by: Claude Opus 5.5